fix: merge system messages for llama.cpp compatibility#10
Open
winmutt wants to merge 1 commit intojoshuadavidthomas:mainfrom
Open
fix: merge system messages for llama.cpp compatibility#10winmutt wants to merge 1 commit intojoshuadavidthomas:mainfrom
winmutt wants to merge 1 commit intojoshuadavidthomas:mainfrom
Conversation
- Merge memory blocks, provider system content, and journal instructions into a single system message at index 0 - Fixes 'System message must be at the beginning' error with Qwen 3.5 when using llama.cpp/Jinja templates - Add unit tests for system message transformation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Using the opencode-agent-memory plugin with Qwen 3.5 via llama.cpp results in:
Root Cause
The
experimental.chat.system.transformhook adds memory blocks and journal instructions to system messages without merging pre-existing system messages. When the provider already has multiple system messages, the plugin leaves them as multiple messages, which violates llama.cpp Jinja template requirements.Solution
Merge all system messages (memory blocks, provider content, journal instructions) into a single system message at index 0.
Testing
Added unit tests in
src/plugin.test.tsto verify: