Skip to content

NO-2077: sync SignatureView URL state and avoid duplicate change events #312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vivekjyani wants to merge 2 commits into
base: main
Choose a base branch
from
Open

NO-2077: sync SignatureView URL state and avoid duplicate change events #312

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eda34f6
sync signature URL state and avoid duplicate change events
vivekjyani Apr 15, 2026
00e6fd2
Add test for signature field in changehandler
vivekjyani Apr 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions JoyfillSwiftUIExample/JoyfillUITests/ChangeUITests/OnChangeHandlerUITests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2603,6 +2603,30 @@ final class OnChangeHandlerUITests: JoyfillUITestsBaseClass {
deleteSelectedImages()
}

func testSignatureCoordinatess() throws {
guard UIDevice.current.userInterfaceIdiom == .pad else {
return
}

let pageSelectionButton = app.buttons.matching(identifier: "PageNavigationIdentifier")
let pageSheetSelectionButton = app.buttons.matching(identifier: "PageSelectionIdentifier")

pageSelectionButton.element(boundBy: 0).tap()
pageSheetSelectionButton.element(boundBy: 3).tap()
pageSelectionButton.element(boundBy: 1).tap()
pageSheetSelectionButton.element(boundBy: 3).tap()

let signatureButtons = app.buttons.matching(identifier: "SignatureIdentifier")
let leftSignatureButton = signatureButtons.element(boundBy: 0)
let rightSignatureButton = signatureButtons.element(boundBy: 1)

leftSignatureButton.tap()
drawSignatureLine()
app.buttons["SaveSignatureIdentifier"].tap()

XCTAssertEqual(rightSignatureButton.label, "Edit Signature", "Signature added on left should reflect on right side.")
}

func deleteSelectedImages() {
app.buttons["ImageDeleteIdentifier"].tap()
}
Expand Down
14 changes: 14 additions & 0 deletions Sources/JoyfillUI/View/Fields/SignatureView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,10 +107,24 @@ struct SignatureView: View {
}
}
.onChange(of: signatureURL) { newValue in
if newValue == (signatureDataModel.signatureURL ?? "") {
return
}
let newSignatureImageValue = ValueUnion.string(newValue)
let fieldEvent = FieldChangeData(fieldIdentifier: signatureDataModel.fieldIdentifier, updateValue: newSignatureImageValue)
eventHandler.onChange(event: fieldEvent)
}
.onChange(of: signatureDataModel.signatureURL ?? "") { latestURL in
guard latestURL != signatureURL else {
return
}
signatureURL = latestURL
if latestURL.isEmpty {
signatureImage = nil
} else {
loadImageFromURL()
}
}
}

func loadImageFromURL() {
Expand Down
Loading