This repository was archived by the owner on Oct 3, 2018. It is now read-only.
Failing test for multiple smiley emoticon#62
Open
leoasis wants to merge 1 commit intojoypixels:masterfrom
Open
Failing test for multiple smiley emoticon#62leoasis wants to merge 1 commit intojoypixels:masterfrom
leoasis wants to merge 1 commit intojoypixels:masterfrom
Conversation
Contributor
|
Haha the test name is really funny |
|
Looks like @leoasis is right, we should be able to fix this by making sure we match |
Contributor
|
Do you think you could maybe give it a go @trevorah? |
|
Yep, it just requires a little bit of time as |
Contributor
|
Awesome, thanks! 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a failing test case for #48
As said there, the problem is that the named emoji pattern matches
:D:but it's not a valid emoji, and then the correct smiley pattern is not tested.