Fixed issue with empty delimiter / separator / qualifier / escape charac...#72
Open
DavidRip wants to merge 1 commit intojprichardson:masterfrom
Open
Fixed issue with empty delimiter / separator / qualifier / escape charac...#72DavidRip wants to merge 1 commit intojprichardson:masterfrom
DavidRip wants to merge 1 commit intojprichardson:masterfrom
Conversation
Owner
|
Please include a test that demonstrates the error before your fix. The test should pass after your fix is applied. Thanks. |
|
Not a bug, an empty string is a truthy value. By changing it to the proposed changes you lose the implicit method contract. There shouldn't be any cases where an empty delimiter would be needed, but if it is needed, it should follow the method contract and return a string delimited by |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Had an issue while trying to implement an empty delimiter (""). Please see my fix below.