Skip to content

Conversation

@deivid-rodriguez
Copy link
Contributor

@deivid-rodriguez deivid-rodriguez commented Jun 12, 2021

CI is running into an error reading

unsupported Java version: 11

Using a newer jruby seems to fix it.

EDIT: I'm reusing this PR with a different intention from the original one. Some commits present in the original version of this PR (which intended to add Java 11 support) were introduced directly to the master branch, and some of them broke Java 8 support. This PR now restores Java 8 support, and also brings the additional changes resulting from rebasing the original changes against the new master branch.

@deivid-rodriguez
Copy link
Contributor Author

Still a WIP since I want to work on some stuff that I skipped when I shouldn't, but I have a green baseline now supportting jruby 9.2 and java 11: https://github.com/deivid-rodriguez/jruby-maven-plugins/actions/runs/964460637.

@deivid-rodriguez deivid-rodriguez marked this pull request as draft June 23, 2021 13:58
@deivid-rodriguez deivid-rodriguez mentioned this pull request Jun 23, 2021
It makes it much easier to troubleshoot errors.
Wrapper generated through `mvn -N io.takari:maven:0.7.7:wrapper -Dmaven=3.6.3`.
@deivid-rodriguez deivid-rodriguez changed the title Use a jruby that supports java 11 Restore java 8 support Oct 29, 2021
@deivid-rodriguez
Copy link
Contributor Author

Hei @mkristian, I see that you pushed some of the patches that used to live in this WIP PR to master and released 2.0.0. I was just trying things and wasn't really expecting anything to be merged as it was, but I'm glad things are moving forward.

Anyways, I was working on fixing CI for jruby/ruby-maven#4, since we need it (or at least it'd be desirable) to be able to release a new version. However, we're running into a rubygems errors due to polyglot-ruby using a version of gem-maven-plugin that did not include #106, which was released with 2.0.0.

So I head over polyglot-ruby to get the version of gem-maven-plugin they use upgraded and opened takari/polyglot-maven#236. However, when testing locally I run into the following error:

[ERROR] Failed to execute goal de.saumya.mojo:gem-maven-plugin:2.0.0-1:initialize (default) on project polyglot-ruby: Execution default of goal de.saumya.mojo:gem-maven-plugin:2.0.0-1:initialize failed: Unable to load the mojo 'initialize' in the plugin 'de.saumya.mojo:gem-maven-plugin:2.0.0-1' due to an API incompatibility: org.codehaus.plexus.component.repository.exception.ComponentLookupException: de/saumya/mojo/gem/InitializeMojo has been compiled by a more recent version of the Java Runtime (class file version 55.0), this version of the Java Runtime only recognizes class file versions up to 52.0

That made me realize that jruby-maven-plugins unintentionally dropped support for Java 8. So I came back here and rebased this PR, restoring Java 8 support. With this PR in place, takari/polyglot-maven#236 is almost green (one single failure which I would need to investigate).

Can you review this and let me know if it makes sense to you?

Copy link
Member

@mkristian mkristian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@deivid-rodriguez
Copy link
Contributor Author

Awesome @mkristian, thanks so much! Looking forward for a new release including this 💪.

@mkristian mkristian merged commit d91511c into jruby:master Nov 1, 2021
@mkristian
Copy link
Member

let me release this today . . .

@deivid-rodriguez deivid-rodriguez deleted the fix_ci branch November 1, 2021 14:37
@headius headius added this to the pre-3.0.0 milestone Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants