Remove usage of Rack::Utils.bytesize #252
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
LOL. I guess CI is still not quite there. @jlahtinen Can you also fix: src/main/ruby/jruby/rack/error_app.rb for the same use of bytesite. That should eliminate any use of that method. |
Member
|
CI looks fine, it's just that the dependency upload part (for GitHub security checking) is not working (and disabled on master for that reason). I'm going to merge this for 1.2.3 and we can chat with @kares if a similar fix and update to newer Rack would be appropriate for 1.1.x. |
Member
|
Correction: disabled except for master because PRs should not upload dependencies. |
|
Have you released this fix yet? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also rack/rack@7b5820f