-
Notifications
You must be signed in to change notification settings - Fork 205
Also test against java 15 #501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
My .zshrc locally, needed ...perhaps we need such details, too? |
|
The
Is that configuration to fix that? |
|
Mmmmm, there are also some failures on the rake 11 job... I'll rerun to see whether they are flakies or not. |
|
Alright, so rake 11 failed (might be flaky or not, not yet sure), and rake 10 is hanging, so... Let me propose my solution for everything: drop support for rake 10 and 11 😆. What do you think? |
f7d5c14 to
5160e22
Compare
|
@deivid-rodriguez Good, ambitious pace! |
|
Flakies were independent from |
5160e22 to
2513652
Compare
|
Funny we get these warnings on java 16:
I'll add your suggestion. |
|
Oof java 8 complained https://github.com/jruby/warbler/runs/2801902936#step:4:19 |
|
Yeah, java 8 does not understand |
2c0e965 to
8344aca
Compare
|
I don't know why the options are not taking effect. It seems like the only java consistenty green is java 15. Should we just switch java 8 with java 15? My main motivation here is to get a local enviromnent that matches CI but I'd rather upgrade my java version that downgrade it to achieve that. |
be5b381 to
4a365ed
Compare
|
I went with my last proposal in the end. |
|
@deivid-rodriguez My friend was like "think of LTS" https://www.oracle.com/java/technologies/java-se-support-roadmap.html
But I lean towards "if 11 can't build, we don't have the bandwidth to fix that, now, toss it". |
|
I see, maybe test on java 8 and 15 for now, and update that to 8 and 17, or maybe just 17 when it's released and we can make it pass? |
4a365ed to
b58b4ae
Compare
|
@deivid-rodriguez That sounds prudent, and will probably work! I hope to create some more clarity around "what is the golden matrix we want to strive for". |
|
I think the latest LTS and the latest non-LTS is a good goal. For now the second to last LTS, and the second to last non-LTS seems like a start :) |
I want to make sure things are fine on java 11 since that's the version I have installed locally.