Remove backup-server workflow surfaces and fix blank system setting defaults

[jruszo]

Summary

• Treat blank choice-valued system settings as their schema defaults so storage_type reloads as local and the storage E2E flow succeeds.
• Remove backup-server settings and workflow backup/rollback UI and API surfaces from the SPA and backend contracts.
• Keep goinception for internal SQL review/execution paths, but make the connection test goinception-only.
• Add regression coverage for system settings, workflow submission behavior, and the removed rollback route.

Testing

• docker exec datamingle-app pytest --cov --cov-report xml
• docker exec datamingle-app python manage.py test api_core.legacy_tests.TestSystemSettings api_core.legacy_tests.TestWorkflow
• cd frontend && npm run build
• cd frontend && npm run test:unit
• cd frontend && E2E_START_FRONTEND=1 npm run e2e:test -- system-settings.spec.ts
• cd frontend && E2E_START_FRONTEND=1 npm run e2e:test -- workflow-smoke.spec.ts
• cd frontend && npm run e2e
• black --check .

Summary by CodeRabbit

• Refactor

  • Removed goInception remote backup configuration settings from system settings
  • Removed workflow rollback API endpoint and related functionality
  • Removed "Backup SQL" workflow option from creation and submission flows
  • Removed backup-related metadata fields from workflow responses

• Enhancements

  • Improved configuration value handling to return default values for choice fields when empty
  • Added "local" storage type as a supported option (defaults when unconfigured)

• Tests

  • Updated test coverage to reflect removal of backup and rollback features

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 1f4c1d27-8534-4d65-a785-e507acd330fa

📥 Commits

Reviewing files that changed from the base of the PR and between f68302b and 509ffa5.

📒 Files selected for processing (17)

• api_admin/settings.py
• api_core/legacy_tests.py
• api_core/views.py
• api_workflows/serializers.py
• api_workflows/urls.py
• api_workflows/views.py
• common/check.py
• coverage.xml
• frontend/src/features/settings/pages/SettingsSystemPage.vue
• frontend/src/features/settings/system-settings.ts
• frontend/src/features/workflows/api.ts
• frontend/src/features/workflows/pages/ExportWorkflowCreatePage.vue
• frontend/src/features/workflows/pages/WorkflowCreatePage.vue
• frontend/src/features/workflows/pages/WorkflowSqlEditorPage.vue
• frontend/src/lib/api.ts
• frontend/tests/e2e/support/workflow-helpers.ts
• frontend/tests/e2e/workflow-smoke.spec.ts

💤 Files with no reviewable changes (9)

• frontend/src/features/workflows/api.ts
• frontend/tests/e2e/support/workflow-helpers.ts
• frontend/src/features/workflows/pages/WorkflowCreatePage.vue
• frontend/src/lib/api.ts
• api_workflows/urls.py
• api_workflows/views.py
• frontend/src/features/workflows/pages/ExportWorkflowCreatePage.vue
• frontend/src/features/workflows/pages/WorkflowSqlEditorPage.vue
• frontend/src/features/settings/pages/SettingsSystemPage.vue

---

📝 Walkthrough

Walkthrough

This PR removes workflow backup toggle, rollback API endpoint, and goInception remote backup configuration fields. It simplifies goInception connectivity to use only primary credentials while eliminating backup-specific database connection configuration. The is_backup workflow field now defaults to False unconditionally, and associated UI components, serializer fields, and type definitions are removed across both backend and frontend.

Changes

Backup and Rollback Feature Removal

Layer / File(s)	Summary
Data Shape / Types api_admin/settings.py, frontend/src/lib/api.ts, api_workflows/serializers.py	Removed inception_remote_backup_* settings and enable_backup_switch from schema; removed is_backup, is_can_rollback, allow_backup_toggle from workflow API types; stripped is_backup field in serializer input handling.
System Settings & Validation common/check.py, api_admin/settings.py	Updated VALID_STORAGE_TYPES to include "local"; rewrote validate_go_inception_payload to connect using only go_inception_* fields instead of inception_remote_backup_*; enhanced _get_config_value to default choice fields when blank.
Core API Logic api_core/views.py, api_workflows/views.py	Removed backup/rollback connection logic from debug endpoint; removed rollback download view and _rollback_download_content helper; stopped including backup metadata in workflow detail serialization and submission responses; always set is_backup=False in workflow creation.
API Routes api_workflows/urls.py	Removed /api/v1/workflow/<id>/rollback/ route.
Frontend Types & Re-exports frontend/src/lib/api.ts, frontend/src/features/workflows/api.ts	Removed WorkflowRollbackRecord type and fetchWorkflowRollback function; removed re-exports of removed rollback/backup types and functions.
Frontend Settings UI frontend/src/features/settings/system-settings.ts, frontend/src/features/settings/pages/SettingsSystemPage.vue	Removed inception_remote_backup_* fields from goInception section and enable_backup_switch from sql-release section; adjusted test payload to exclude removed backup host/port/user/password settings.
Frontend Workflow UI frontend/src/features/workflows/pages/WorkflowCreatePage.vue, frontend/src/features/workflows/pages/WorkflowSqlEditorPage.vue, frontend/src/features/workflows/pages/ExportWorkflowCreatePage.vue	Removed isBackup form state, backup toggle metadata defaulting logic, and backup toggle UI components; stopped sending is_backup in workflow creation payloads.
E2E Tests & Helpers frontend/tests/e2e/support/workflow-helpers.ts, frontend/tests/e2e/workflow-smoke.spec.ts	Removed expectWorkflowBackupFlag and setBackupSwitchEnabled helpers; removed DML backup-specific test scenarios; moved system config resets to beforeEach; removed backup flag assertions.
Test Expectations api_core/legacy_tests.py	Updated workflow detail/metadata tests to assert absence of allow_backup_toggle, enable_backup_switch, is_can_rollback fields; replaced rollback endpoint test with route-not-found assertion; rewrote backup submission tests to verify is_backup always defaults/stays False; updated goInception test success message expectation; added storage_type defaulting validation.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

• [codex] Add SPA system settings management #25: Related — modifies the same system settings schema and goInception validation logic that this PR removes or repurposes; directly overlaps on SYSTEM_SETTINGS_SCHEMA and validate_go_inception_payload changes.
• Remove bootstrap frontend and keep SPA routes only #38: Related — both PRs remove legacy rollback API endpoints, views, and backup-related fields; the retrieved PR removes Bootstrap-based views that depended on the rollback/backup functionality removed here.
• [codex] Add workflow SQL parsing and separate DDL create flow #20: Related — the retrieved PR introduces WorkflowRollbackDetail, fetchWorkflowRollback, and related types that this PR removes entirely, making them inverse changes to the same codebase areas.

Poem

🐰 Backup and rollback bid adieu,
GoInception keeps just what is true.
Simpler flows, with False the way,
No toggles dance, no files stay.
The schema sings of what remains.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 8.70% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and specifically describes the primary changes: removing backup-server workflow surfaces and fixing blank system setting defaults.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/remove-backup-server-features

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Review rate limit: 0/1 reviews remaining, refill in 60 minutes.}

_{Comment @coderabbitai help to get the list of available commands and usage tips.}