Always pass account when specified#55
Merged
jscarle merged 1 commit intojscarle:masterfrom Nov 8, 2023
Merged
Conversation
3cde40d to
d001603
Compare
Owner
|
Looks good, thanks for the contribution! |
jscarle
approved these changes
Nov 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Specifying an account for
opis not only useful when required. In an app-integrated setup where you have multiple accounts configured (like the scenario of a company account and a private one), passing the account when provided is critical in resolving requests.This change keeps existing behaviour of excluding the parameter from some commands and failing when an account is required, but not provided. Outside of that, the account parameter is now always provided if set.
Example of use in app-integrated context: