Skip to content

Always pass account when specified#55

Merged
jscarle merged 1 commit intojscarle:masterfrom
AngryAnt:MultiAccountFix
Nov 8, 2023
Merged

Always pass account when specified#55
jscarle merged 1 commit intojscarle:masterfrom
AngryAnt:MultiAccountFix

Conversation

@AngryAnt
Copy link
Contributor

@AngryAnt AngryAnt commented Nov 3, 2023

Specifying an account for op is not only useful when required. In an app-integrated setup where you have multiple accounts configured (like the scenario of a company account and a private one), passing the account when provided is critical in resolving requests.

This change keeps existing behaviour of excluding the parameter from some commands and failing when an account is required, but not provided. Outside of that, the account parameter is now always provided if set.

Example of use in app-integrated context:

s_Manager = new OnePasswordManager (
	new OnePasswordManagerOptions
	{
		AppIntegrated = true,
		Path = kBinariesPath,
		Executable = "op"
	});

s_Manager.UseAccount (kAccountID);

@jscarle
Copy link
Owner

jscarle commented Nov 8, 2023

Looks good, thanks for the contribution!

@jscarle jscarle merged commit e475501 into jscarle:master Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants