Skip to content

[Modify] modify contributor handler #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gimdongwoo merged 1 commit into from
Dec 2, 2018
Merged

[Modify] modify contributor handler #220

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
68 changes: 33 additions & 35 deletions handlers/github.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,44 +40,42 @@ router.get('/repos', (req: Request, res: Response, next: NextFunction) => {
});

router.get('/contributors', async (req: Request, res: Response, next: NextFunction) => {
try {
const body = await cache.wrap(
'github/contributors',
async () => {
const getDetails = async login => {
const { data } = await axios(`${apiBaseUrl}/users/${login}`, {
headers: {
...headers,
'Content-Type': 'application/json; charset=utf-8',
'User-Agent': `${name}/${version}`,
},
});
return data as IContributor;
};

let promises = [];
let contributors = await readContributorFile();
contributors.forEach(i => {
promises.push(getDetails(i.login));
const body = await cache.wrap(
'github/contributors',
async () => {
const getDetails = async login => {
const { data } = await axios(`${apiBaseUrl}/users/${login}`, {
headers: {
...headers,
'Content-Type': 'application/json; charset=utf-8',
'User-Agent': `${name}/${version}`,
},
});
return data as IContributor;
};

return await Promise.all(promises)
.then(values => {
return values as IContributor[];
})
.catch(err => {
console.log(err);
next(err);
});
},
{ ttl },
);
let promises = [];
let contributors = await readContributorFile();
contributors.forEach(i => {
promises.push(
getDetails(i.login)
.then(data => data)
.catch(err => {
console.log(err);
return err;
}),
);
});

return res.status(200).json(body);
} catch (err) {
console.log(err);
return next(err);
}
return await Promise.all(promises).then(values => {
values = values.filter(value => !(value instanceof Error));
return values as IContributor[];
});
},
{ ttl },
);

return res.status(200).json(body);

function readContributorFile(): Promise<IContributor[]> {
return new Promise(resolve => {
Expand Down