Skip to content

Conversation

@asamuzaK
Copy link
Contributor

w3c/webref#1647 is fixed.

Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

@domenic domenic merged commit 7515db5 into jsdom:main Jan 11, 2026
3 checks passed
@asamuzaK
Copy link
Contributor Author

css-syntax-patches-for-csstree had a bug.
csstools/postcss-plugins#1760

When releasing a new cssstyle, make sure to update it again.

@asamuzaK asamuzaK deleted the syscolor branch January 11, 2026 09:51
@domenic
Copy link
Member

domenic commented Jan 11, 2026

Can you send an update PR with a test that would catch the bug? (Maybe such a test already exists and that's how you caught it.)

@asamuzaK
Copy link
Contributor Author

https://wpt.live/css/css-backgrounds/parsing/background-clip-invalid.html

cssstyle@5.3.4 passes
cssstyle@5.3.7 fails
Maybe it has been failing since v5.3.5 which we switched to @webref/css from v6.x to v8.x
422b90c

Our current jsdom main branch includes v5.3.4, so it passes.

If we release jsdom including cssstyle@5.3.7 at this point, we could catch the error, but I don't think that would make much sense.
I think it would be better to leave it as it is and check that the tests pass (no errors) when we release csstree.
What do you think?

@domenic
Copy link
Member

domenic commented Jan 11, 2026

Sure, that sounds good. Thanks for the detailed explanation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants