Align code style with jsdom #300
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domenic
reviewed
Jan 12, 2026
lib/CSSStyleDeclaration.js
Outdated
| this._readonly = true; | ||
| // FIXME: The `_readonly` flag should initially be `false` to be editable, | ||
| // but should eventually be set to `true`. | ||
| this._readonly = false; |
Member
There was a problem hiding this comment.
This seems like a non-style change. Are there others like it I should keep an eye on?
Perhaps it would be better to separate the non-style changes into a different PR?
eslint.config.mjs
Outdated
| globals: globals.node | ||
| }, | ||
| rules: { | ||
| "func-style": "off" |
Member
There was a problem hiding this comment.
Why not also update test files? What is the benefit of the inconsistency?
Contributor
Author
There was a problem hiding this comment.
Added just in case. Removed.
domenic
approved these changes
Jan 13, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #286
Motivation
We will apply a code style that largely matches jsdom's.
The objective is to unify code styling across the jsdom project to improve readability and maintainability, as well as to facilitate debugging.
Changes from the existing code style
.editorconfigfrom jsdom.eslint.config.mjsto nearly match jsdom's.function foo() {}) instead of arrow function expressions (const foo = () => {}).require())Differences from jsdom
"consistent-return": "off"to therulesto accommodate Prettier usage."func-style": "off"for test files.