Android support #43
Open
Android support #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jselbie
reviewed
Oct 24, 2021
Author
|
@jselbie any update? |
|
这是来自QQ邮箱的假期自动回复邮件。
您好，我最近正在休假中，无法亲自回复您的邮件。我将在假期结束后，尽快给您回复。
|
jselbie
reviewed
Jan 24, 2022
| #elif __has_include(<sys/termios.h>) | ||
| #include <sys/termios.h> | ||
| #endif | ||
|
|
Owner
There was a problem hiding this comment.
Since has_include isn't standard, please wrap with macro to detect GCC/G++
#ifdef __GNUC__
#if __has_include(<termios.h>)
#include <termios.h>
#elif __has_include(<sys/termios.h>)
#include <sys/termios.h>
#endif
#else
#include <termios.h>
#endif
Repository owner
deleted a comment from
Neustradamus
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support (allows compilation) for Android. On Android the standard location is not
<sys/termios.h>, instead<termios.h>.The Android NDK has the
__ANDROID__macro that can be used (clang also) when used as a standalone toolchain, the Android.mk sets theANDROIDmacro. So I've checked for both.