Skip to content

Conversation

@niteshsinghal85
Copy link
Contributor

Closes #1876

QUALITY CHECKLIST

@codecov
Copy link

codecov bot commented Dec 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.21%. Comparing base (1e207f5) to head (c7f3642).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1879   +/-   ##
=======================================
  Coverage   92.21%   92.21%           
=======================================
  Files         437      437           
  Lines       14866    14866           
  Branches     2451     2451           
=======================================
  Hits        13708    13708           
  Misses        713      713           
  Partials      445      445           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@niteshsinghal85 niteshsinghal85 marked this pull request as ready for review December 10, 2025 14:51
Copy link
Member

@bkoelman bkoelman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks great!

There are still a few places not updated in /docs. Can you search for "int" (match whole word) and update accordingly?

@niteshsinghal85
Copy link
Contributor Author

Thanks, looks great!

There are still a few places not updated in /docs. Can you search for "int" (match whole word) and update accordingly?

Updated for relevant places

Copy link
Member

@bkoelman bkoelman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@bkoelman bkoelman merged commit 02f654c into json-api-dotnet:master Dec 11, 2025
15 checks passed
@niteshsinghal85 niteshsinghal85 deleted the replace-int-with-long-forid branch December 11, 2025 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Replace int with long as ID type in samples/docs/tests

3 participants