Only call getEffectiveDefaults when needed#128
Merged
kallestenflo merged 1 commit intojson-path:masterfrom Sep 29, 2015
Merged
Conversation
The call to `getEffectiveDefaults` will make `json-smart` dependency required for processing. By removing the call when not needed `json-smart` can be safely excluded. In addition the logger was removed since it was not being used.
kallestenflo
added a commit
that referenced
this pull request
Sep 29, 2015
Only call getEffectiveDefaults when needed
This was referenced Sep 29, 2015
|
Hi, The merged commit only partially solves the problem. There are code lines that internally create a new configuration object (see https://github.com/jayway/JsonPath/blob/json-path-2.1.0/json-path/src/main/java/com/jayway/jsonpath/internal/filter/ValueNode.java#L778) but only copy the provided json provider, not the mapping provider. In consequence, the code proposed in this fix and on current master still calls Cheers, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The call to
getEffectiveDefaultswill makejson-smartdependencyrequired for processing. By removing the call when not needed
json-smartcan be safely excluded.In addition the logger was removed since it was not being used.