Fix hyper-schema meta-schema self link. #268
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"id" became "$id", and we handle "$" through percent-encoding URI Templates reserve "$", but do not specify how percent-encoding is to be used, except that implementations should be consistent about it. We document that we always percent-decode variables before resolving them.
awwright
approved these changes
Mar 3, 2017
Member
awwright
left a comment
awwright
left a comment
There was a problem hiding this comment.
This seems ugly, but I suppose it's correct
Contributor
Author
|
@awwright yeah, definitely ugly, but we intend to revisit this sort of thing soon anyway. This will get us through "draft-06" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"id" became "$id", and we handle "$" through percent-encoding
URI Templates reserve "$", but do not specify how percent-encoding
is to be used, except that implementations should be consistent about
it. We document that we always percent-decode variables before
resolving them.