Merged
Conversation
jsongo
force-pushed
the
feat/configurable-timeout
branch
2 times, most recently
from
83cb136 to
84e2284
Compare
- Add --timeout CLI option and OPEN_MOTION_RENDER_TIMEOUT env var - Set default timeout to 300,000ms (5 minutes) - Propagate timeout to Playwright's goto, waitForLoadState, and waitForFunction - Use page.setDefaultTimeout and page.setDefaultNavigationTimeout in renderer - Fix render hanging by only waiting for networkidle on first frame - Fix init template by explicitly setting __OPEN_MOTION_READY__ in rendering mode - Auto-detect pnpm for init template - Bump version to 0.1.9 Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
jsongo
force-pushed
the
feat/configurable-timeout
branch
from
84e2284 to
1c7c752
Compare
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Remove parentheses and use ; instead of && before pkill to ensure the server is killed even if the render command fails. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This adds global quick start instructions and specific examples for the render command to the CLI help output using commander's addHelpText method. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OPEN_MOTION_RENDER_TIMEOUT环境变量，默认超时时间从 30s/120s 提升至 300,000ms (5分钟)。render命令添加了--timeoutCLI 参数（单位为 ms），优先级高于环境变量。page.goto、page.waitForLoadState和page.waitForFunction等关键步骤。0.1.7。Test plan
OPEN_MOTION_RENDER_TIMEOUT=1000 open-motion render ...验证环境变量是否能正确触发 1s 超时。open-motion render ... --timeout 2000验证 CLI 参数是否能正确触发 2s 超时。TimeoutError。🤖 Generated with Claude Code