Github rate limit error WITH authentication

[sergei-maertens]

Hi, I'm not sure if this is on jspm's end or Github's, but in Travis I'm running into broken builds because of the dreaded Rate limit errors.

Before today, this was working perfectly. The error I'm seeing because of jspm install is:

GitHub rate limit reached, with authentication enabled.

The build log is publicly visible: https://travis-ci.org/modelbrouwers/modelbrouwers/builds/144385431

As I said, I have set up the token before, and jspm correctly detects that auth is enabled. What gives?

[guybedford]

This is a regression unfortunately.

When we removed usernames from the github authentication process in #91 this stopped private authentication from working as private github needs the username and the token as the password.

It looks like we will need to revert the previous PR work, or merge in the ability to work with usernames again.

//cc @tamird

[tamird]

Am I missing something? I don't see that error in the build log at all.

private github needs the username and the token as the password.

Now I'm completely lost. What does this have to do with private github? Everything here appears to be public.

[guybedford]

@tamird when configuring github credentials to use private repos, it is apparently necessary to use the username and token as the password in order for the authentication to work.

[guybedford]

And thanks for the quick response!

[tamird]

@guybedford how did you determine that? What does that have to do with this issue?

[guybedford]

@adamburgess reported this along with a PR at #95 (comment). This issue is exactly because the private repo authentication is failing, and thus hitting the rate limit.

[sergei-maertens]

For the record, all of this build should be public.

On Jul 15, 2016 17:31, "Tamir Duberstein" notifications@github.com wrote:

@guybedford https://github.com/guybedford how did you determine that?
What does that have to do with this issue?

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#97 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AFQ01rWjZzPV-WLtZtlx9MS5YD_3mcEuks5qV6fagaJpZM4JLaqu
.

[guybedford]

@sergei-maertens is it a private github account though, even if public?

[guybedford]

(I may just be showing my ignorance here though)

[tamird]

This seems to have absolutely nothing to do with whatever is being discussed in #94.

@sergei-maertens I don't see any JSPM-related error in the log you linked.
@guybedford sounds to me like this error (wherever it occurred) was possibly a real case of hitting GH's API limit?

[sergei-maertens]

it's my personal github account, the very same that I'm using here to comment.

The build log in Travis seems to have changed because the build was triggered by something else, I'll see if I can dig it up somewhere again.

[sergei-maertens]

This one has the same issue: https://travis-ci.org/modelbrouwers/modelbrouwers/builds/143824722

Exerpt:

�[0Ktravis_time:start:2547ba90
�[0K$ jspm config registries.github.auth $GITHUBTOKEN

travis_time:end:2547ba90:start=1468224022243393123,finish=1468224022780825407,duration=537432284
�[0Ktravis_fold:end:before_script.3
�[0Ktravis_fold:start:before_script.4
�[0Ktravis_time:start:08f59710
�[0K$ jspm install
     Looking up �[36mnpm:babel-core�[39m
     Looking up �[36mnpm:babel-runtime�[39m
     Looking up �[36mnpm:core-js�[39m
     Looking up �[36mnpm:URIjs�[39m
     Looking up �[36mnpm:aurelia-http-client�[39m
     Looking up �[36mnpm:aurelia-pal�[39m
     Looking up �[36mnpm:aurelia-pal-browser�[39m
     Looking up �[36mnpm:perfect-scrollbar�[39m
     Looking up �[36mnpm:q�[39m
     Looking up �[36mnpm:string.prototype.startswith�[39m
     Creating registry cache...
     Looking up �[36mgithub:components/jquery�[39m
     Looking up �[36mgithub:components/jqueryui�[39m
     Looking up �[36mgithub:twbs/bootstrap�[39m
     Looking up �[36mgithub:components/handlebars.js�[39m
     Looking up �[36mgithub:systemjs/plugin-json�[39m
     Looking up �[36mgithub:systemjs/plugin-css�[39m
     Looking up �[36mgithub:jspm/nodelibs-url�[39m
     Looking up �[36mgithub:twitter/typeahead.js�[39m
     Looking up �[36mgithub:sergei-maertens/django-ponyjs�[39m
     Downloading �[36mgithub:components/handlebars.js@2.0.0�[39m
     Downloading �[36mgithub:systemjs/plugin-json@0.1.0�[39m
     Downloading �[36mgithub:systemjs/plugin-css@0.1.13�[39m
     Downloading �[36mgithub:jspm/nodelibs-url@0.1.0�[39m
     Downloading �[36mgithub:sergei-maertens/django-ponyjs@0.1.2�[39m
     Downloading �[36mgithub:components/jquery@2.2.1�[39m
     Downloading �[36mgithub:components/jqueryui@1.11.4�[39m
     Downloading �[36mgithub:twbs/bootstrap@3.3.5�[39m
     Downloading �[36mgithub:twitter/typeahead.js@0.11.1�[39m
     Looking up �[36mnpm:url�[39m
     Downloading �[36mgithub:components/handlebars.js@3.0.3�[39m
     Looking up �[36mgithub:js-cookie/js-cookie�[39m
     Downloading �[36mgithub:js-cookie/js-cookie@2.1.0�[39m

�[33m�[1mwarn �[22m�[39mError on download for �[36mgithub:twbs/bootstrap�[39m

     GitHub rate limit reached, with authentication enabled.
     The rate limit will reset in �[36m5 minutes�[39m.

�[31m�[1merr  �[22m�[39mError downloading �[36mgithub:twbs/bootstrap�[39m.

�[33m�[1mwarn �[22m�[39mInstallation changes not saved.

travis_time:end:08f59710:start=1468224022785126821,finish=1468224025060958172,duration=2275831351
�[0K
�[31;1mThe command "jspm install" failed and exited with 1 during .�[0m

Your build has been stopped.

[tamird]

Have you confirmed that this is not a legit case of you having exceeded the API limit?

[sergei-maertens]

I could hardly imagine where, did no local jspm install and there were not
multiple builds running at the same time. I'm not sure where to start
diagnosing the problem, since I can't reproduce it locally either

On Jul 15, 2016 17:41, "Tamir Duberstein" notifications@github.com wrote:

Have you confirmed that this is not a legit case of you having exceeded
the API limit?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#97 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AFQ01koEpwkVjUZ6heIaAhpiYtcKddzZks5qV6oZgaJpZM4JLaqu
.