chore: reintegrate the helpers in the main package#40
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull request overview
This PR merges the previously separate packages/helpers workspace package directly into the main lib/ package (@radiance/gl), simplifying the monorepo structure by eliminating the packages/* workspace and consolidating everything under lib/.
Changes:
- Removes
packages/helpers(its source files are moved tolib/src/helpers/) and updatespnpm-workspace.yamlto only includelib/anddocs/. - Updates
lib/src/index.tsto re-export helpers (loop,onResize,onPointerEvents) directly fromlib/src/helpers/instead of@radiance/helpers. - Migrates and self-contains the
lib/package: newDockerfile,compose.yml,playwright.config.ts, Astro playground, test screenshots, and all supporting infrastructure that previously lived inpackages/gl.
Reviewed changes
Copilot reviewed 16 out of 226 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
pnpm-workspace.yaml |
Replaces packages/* with lib as the sole library workspace package |
packages/helpers/** |
Entirely removed; helpers are now in lib/src/helpers/ |
lib/src/helpers/loop.ts |
Moved from packages/helpers, unchanged; module-level registry has a potential memory/stale reference issue |
lib/src/helpers/onResize.ts |
Moved from packages/helpers; disconnect is not bound to the observer instance |
lib/src/helpers/onPointerEvents.ts |
Moved from packages/helpers; BoundingRect type is no longer publicly exported |
lib/src/helpers/watchBoundingRect.ts |
Renamed UseBoundingRectParams → WatchBoundingRectParams |
lib/src/index.ts |
Adds direct helper exports, removes @radiance/helpers re-export |
lib/Dockerfile |
New self-contained Dockerfile; missing pnpm-lock.yaml copy |
lib/compose.yml |
Simplified build context (no more cross-package context references) |
lib/tests/screenshots.spec.ts |
Visual regression test spec (migrated from packages/gl/tests/) |
lib/src/** |
All other source files migrated from packages/gl/src/ |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Comments suppressed due to low confidence (2)
lib/src/index.ts:54
- The
watchBoundingRectfunction is not exported fromlib/src/index.ts. While it is used internally byonPointerEvents, its companion types (WatchBoundingRectParams,BoundingRect) were previously exported via@radiance/helpers. TheBoundingRecttype is still used in the public signature ofonPointerEvents(as a property ofHandlerArgs), so consumers who need to type that argument will not be able to importBoundingRectdirectly. Either exportwatchBoundingRectand its types fromindex.ts, or re-export theBoundingRecttype separately.
lib/src/helpers/watchBoundingRect.ts:51 - The type
UseBoundingRectParamshas been renamed toWatchBoundingRectParamsin the diff. If any existing external consumers (e.g. docs or downstream packages) were usingUseBoundingRectParamsby name, this is a breaking rename. Ensure the old name is not exposed in any published API surface.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
47ff9c1 to
53c6154
Compare
53c6154 to
93774a4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.