Skip to content

Added support for multiple containers#14

Open
Blazsoul wants to merge 1 commit intojsxtools:mainfrom
Blazsoul:main
Open

Added support for multiple containers#14
Blazsoul wants to merge 1 commit intojsxtools:mainfrom
Blazsoul:main

Conversation

@Blazsoul
Copy link

@Blazsoul Blazsoul commented Nov 16, 2021

From what i have noticed the layoutContainerSet variable is being cleared on each mutation and therefore it has only one container element, I just removed the clear command so it will add all the containers to the set, It seems to function properly with multiple containers on the same page now.

What do you think ?

@jonathantneal
Copy link
Contributor

jonathantneal commented Nov 16, 2021

I like it, @Blazsoul. After if (!doesMatchAllElements) {}, should there be something like this, to clear containers that no longer match?

if (!doesMatchAllElements) { /* ... */ } else {
  for (const element of elements) {
    layoutContainerSet.delete(element)
  }
}

@DEfusion
Copy link

I've just hit this issue too and this PR fixes my issue also

@Blazsoul
Copy link
Author

Blazsoul commented Nov 17, 2021

@jonathantneal I tried to add this piece of code but then it's just blows up all of the responsiveness functionality

@Blazsoul
Copy link
Author

Blazsoul commented Dec 8, 2021

any update ? @jonathantneal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants