Replacing __dirname with process.cwd()#2
Open
nalejandroveron wants to merge 1 commit intojsxtools:masterfrom
Open
Replacing __dirname with process.cwd()#2nalejandroveron wants to merge 1 commit intojsxtools:masterfrom
nalejandroveron wants to merge 1 commit intojsxtools:masterfrom
Conversation
jacobroufa
approved these changes
Aug 31, 2021
jacobroufa
left a comment
jacobroufa
left a comment
There was a problem hiding this comment.
I encountered the same issue with yarn/npm workspaces, and this change resolves my issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are cases (like when you use Yarn workspaces) where the config files cannot be properly resolved using
__dirname. This will make the lookup based onprocess.cwd()which looks to be resolving for both cases.Thanks for this great plugin, tho!