-
Notifications
You must be signed in to change notification settings - Fork 13
Gui test #212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Gui test #212
Conversation
sbillinge
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for these @ludivintchokote
Please could you redo this on a clean branch?
We are using the pytest framework, so we would like the tests in pytest and not unittest. Also, please put all tests in the tests/ directory tree, not under src/GUI
I am guessing that most of this code was auto-generated, which, since we are back-filling absent tests, I think that is ok, and it means that it is probably possible to regenerate it fairly quickly in pytest?
In general, the way we like to write unit tests is to identify the behavior we want to test, and then to write the test that implements that behavior. Since these are backfilling absent tests, I think the way it was done here was fine, modulo the issues that were identified about not being a clean branch and non-informative commit messages. Also, please make sure the add comments in the conversation. Make sure you have the issue that wil lbe closed mentioned and anything that can help the review process, such as showing outputs from running tests locally.
Added: