Skip to content

Conversation

@ludivintchokote
Copy link

Added:

  • Added some unit test files for GUI code

Copy link
Member

@sbillinge sbillinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these @ludivintchokote

Please could you redo this on a clean branch?

We are using the pytest framework, so we would like the tests in pytest and not unittest. Also, please put all tests in the tests/ directory tree, not under src/GUI

I am guessing that most of this code was auto-generated, which, since we are back-filling absent tests, I think that is ok, and it means that it is probably possible to regenerate it fairly quickly in pytest?

In general, the way we like to write unit tests is to identify the behavior we want to test, and then to write the test that implements that behavior. Since these are backfilling absent tests, I think the way it was done here was fine, modulo the issues that were identified about not being a clean branch and non-informative commit messages. Also, please make sure the add comments in the conversation. Make sure you have the issue that wil lbe closed mentioned and anything that can help the review process, such as showing outputs from running tests locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants