Comment big-endian format, the unpacking operator, encryptor creation and encryption call #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I had to struggle to understand the unpacking operator '*' until I found following video https://www.youtube.com/watch?v=YWY4BZi_o28. Cool python feature.
madchucky
changed the title
madchucky
changed the title
CBC mode is chosen because this is what mega is using.
Adding a coming explaining why 'b' needs to be padded up to a length multiple of 4. If the need for padding repeats, we could define a function for it maybe.
madchucky
commented
Dec 7, 2017
Author
madchucky
left a comment
madchucky
left a comment
There was a problem hiding this comment.
Need for padding seems to be repeating, for instance in function "enc_attr" in crypto.py
I still do not know the need of the function though...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had to refresh the notion of endianness and found following video helpful https://www.youtube.com/watch?v=MEyV7moej-k
I guess the idea here is to have the code independent of the platform it is run on, right @juanriaza ?
I struggled to understand the unpacking operator '*' until I found following video https://www.youtube.com/watch?v=YWY4BZi_o28. Cool python feature.
Is the package pycrypto the right one for AES import? Few comments added from there. https://pypi.python.org/pypi/pycrypto "PyCrypto is written and tested using Python version 2.1 through 3.3. Python 1.5.2 is not supported."
Good simple use of pycrypto is demonstrated here https://www.youtube.com/watch?v=fqjdXMu4ZAQ