✨ RecDotGov Tours + Timed Entry#151
Merged
juftin merged 4 commits intojuftin:0.9.0from Jan 18, 2023
Merged
Conversation
jingyuanliang
force-pushed
the
tours
branch
2 times, most recently
from
4f24a76 to
ddbfdde
Compare
Owner
|
👏 👏 I've just started getting a look at this but super exciting! Loving those BaseClass and mixins as well. This is a decent sized refactor but looks to be very well done. I'm looking forward to getting some review on this ASAP. |
juftin
added
enhancement
jingyuanliang
force-pushed
the
tours
branch
4 times, most recently
from
2651b6c to
5739da6
Compare
Owner
|
Added some refactoring here: jingyuanliang#1 This functionality could use some documentation (on the Base Classes and the and simple unit tests @ tests/command_line_tests.sh) |
A tour facility is currently modeled as a campground and each individual tour is a campsite. User interface was not updated yet but the logic does the work as expected.
With this endpoint, available time slots can be extracted. They're attached as equipments on each tour (as campsite).
Flake8 + ABC
Contributor
Author
|
Rebased to eliminate merge from main. |
juftin
changed the title
juftin
added a commit
that referenced
this pull request
Jan 25, 2023
* Add support for tours (ticket and timed-entry) as new providers A tour facility is currently modeled as a campground and each individual tour is a campsite. User interface was not updated yet but the logic does the work as expected. * Add RecreationDotGovDailyTicket and RecreationDotGovDailyTimedEntry With this endpoint, available time slots can be extracted. They're attached as equipments on each tour (as campsite). * RecreationDotGov Tours (#1) Flake8 + ABC * Fix Flake8 lint errors Co-authored-by: Justin Flannery <juftin@juftin.com>
juftin
added a commit
that referenced
this pull request
Jan 25, 2023
* Add support for tours (ticket and timed-entry) as new providers A tour facility is currently modeled as a campground and each individual tour is a campsite. User interface was not updated yet but the logic does the work as expected. * Add RecreationDotGovDailyTicket and RecreationDotGovDailyTimedEntry With this endpoint, available time slots can be extracted. They're attached as equipments on each tour (as campsite). * RecreationDotGov Tours (#1) Flake8 + ABC * Fix Flake8 lint errors Co-authored-by: Justin Flannery <juftin@juftin.com>
juftin
added a commit
that referenced
this pull request
Jan 25, 2023
* Add support for tours (ticket and timed-entry) as new providers A tour facility is currently modeled as a campground and each individual tour is a campsite. User interface was not updated yet but the logic does the work as expected. * Add RecreationDotGovDailyTicket and RecreationDotGovDailyTimedEntry With this endpoint, available time slots can be extracted. They're attached as equipments on each tour (as campsite). * RecreationDotGov Tours (#1) Flake8 + ABC * Fix Flake8 lint errors Co-authored-by: Justin Flannery <juftin@juftin.com>
juftin
added a commit
that referenced
this pull request
Jan 25, 2023
* ✨ RecDotGov Tours + Timed Entry (#151) * Add support for tours (ticket and timed-entry) as new providers A tour facility is currently modeled as a campground and each individual tour is a campsite. User interface was not updated yet but the logic does the work as expected. * Add RecreationDotGovDailyTicket and RecreationDotGovDailyTimedEntry With this endpoint, available time slots can be extracted. They're attached as equipments on each tour (as campsite). * RecreationDotGov Tours (#1) Flake8 + ABC * Fix Flake8 lint errors Co-authored-by: Justin Flannery <juftin@juftin.com> * ✨ RecDotGov Tours + Timed Entry * 📝 New Provider Docs (#190) * 📝 New Provider Docs * 📝 Provider Docs Co-authored-by: jingyuanliang <jingyuanliang@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A tour facility is currently modeled as a campground and each individual tour is a campsite. User interface was not updated yet but the logic does the work as expected.
I'm not an regular user of Python typing so I probably erased some typing info or didn't use it correctly here and there.
Fixes #74.
Description
Has This Been Tested?
Checklist:
BUMP_MAJOR,BUMP_MINOR, orBUMP_PATCHlabel to this PR to increment the version.pre_commiton all my code