Skip to content

✅ Testing Improvements: Cassettes and CLIRunner#155

Merged
juftin merged 27 commits intorelease/0.8.0from
feature/improved_testing
Dec 22, 2022
Merged

✅ Testing Improvements: Cassettes and CLIRunner#155
juftin merged 27 commits intorelease/0.8.0from
feature/improved_testing

Conversation

@juftin
Copy link
Copy Markdown
Owner

@juftin juftin commented Nov 29, 2022 •
edited
Loading

Description

  • Uses VCRpy to serialize API calls during testing
  • Uses the Click CliRunner to test the CLI inside of pytest
  • Includes a Bug Fix on Data Types for IDs

Has This Been Tested?

yeah

Checklist:

  • I've read the contributing guidelines of this project
  • I've added a BUMP_MAJOR, BUMP_MINOR, or BUMP_PATCH label to this PR to increment the version
  • I've installed and used .pre_commit on all my code
  • I have documented my code, particularly in hard-to-understand areas
  • I have made any necessary corresponding changes to the documentation

@juftin juftin added bug Something isn't working BUMP_PATCH testing Testing labels Nov 29, 2022
@juftin juftin self-assigned this Nov 29, 2022
@juftin juftin changed the base branch from main to release/0.8.0 December 22, 2022 03:28
@juftin juftin changed the title Testing Improvements: Cassettes and CLIRunner ✅ Testing Improvements: Cassettes and CLIRunner Dec 22, 2022
@juftin juftin merged commit 7c8fb0b into release/0.8.0 Dec 22, 2022
@juftin juftin deleted the feature/improved_testing branch December 22, 2022 04:13
@juftin juftin mentioned this pull request Dec 22, 2022
Merged
4 tasks
@acaloiaro acaloiaro mentioned this pull request Dec 23, 2022
Merged
juftin added a commit that referenced this pull request Dec 27, 2022
@juftin @acaloiaro
✅ Testing Improvements: Cassettes and CLIRunner (#155)
cff7c1a 
* Add going to camp support

* Fix type hints for _fetch_nested_keys

* Add missing 'provider' argument to 'campsites()'

* Fix invalid equipment parameter name

* Fix provider config for recreation-areas

* flake8 can get some satisfaction

* Add python tests for going to camp search

* Fix recursive resource fetch bug

* Revert back to requipment-id instead of changing the --equipment API

* Testing Improvements: Cassettes and CLIRunner

* Testing Improvements: Cassettes and CLIRunner

* Testing Improvements: Cassettes and CLIRunner

* Testing Improvements: Cassettes and CLIRunner

* Testing Improvements: Cassettes and CLIRunner

* Check off the final TODO list

* Testing Improvements: Cassettes and CLIRunner

* Testing Improvements: Cassettes and CLIRunner

* Update camply/search/search_going_to_camp.py

* Update camply/search/search_going_to_camp.py

* Refactor 'self->cls' in validator

* Add multiple search window support to search library

* Coerce start date to 'today' when it's in the past

* GoingToCamp + Tests

* 🚧 Merging Latest

Co-authored-by: Adriano Caloiaro <code@adriano.fyi>
Co-authored-by: Adriano <3331648+acaloiaro@users.noreply.github.com>
juftin added a commit that referenced this pull request Jan 18, 2023
@juftin @jingyuanliang
@semantic-release-bot @acaloiaro
✨ RecDotGov Tours + Timed Entry (#188)
a5807ac 
* Add support for tours (ticket and timed-entry) as new providers

A tour facility is currently modeled as a campground and each individual
tour is a campsite. User interface was not updated yet but the logic
does the work as expected.

* Add RecreationDotGovDailyTicket and RecreationDotGovDailyTimedEntry

With this endpoint, available time slots can be extracted. They're
attached as equipments on each tour (as campsite).

* Flake8 + ABC

* Add support for tours (ticket and timed-entry) as new providers

A tour facility is currently modeled as a campground and each individual
tour is a campsite. User interface was not updated yet but the logic
does the work as expected.

* Add RecreationDotGovDailyTicket and RecreationDotGovDailyTimedEntry

With this endpoint, available time slots can be extracted. They're
attached as equipments on each tour (as campsite).

* RecreationDotGov Tours (#1)

Flake8 + ABC

* Fix Flake8 lint errors

* 🐛 semantic-release

* 🔖 0.7.4

# [v0.7.4](v0.7.3...v0.7.4) (2022-12-22)

## 🐛 Bug Fixes
- [`6d7c682`](6d7c682)  semantic-release

* 👷 publish pre-releases

* 📝 Docs + GA

* 🐛 Docker Home Directory (#173)

* 🔖 0.7.5

# [v0.7.5](v0.7.4...v0.7.5) (2022-12-22)

## 🐛 Bug Fixes
- [`6c92220`](6c92220)  Docker Home Directory (#173) (Issues: [`#173`](#173))

* 🐛 CI/CD Triggers (#174)

* 🔖 0.7.6

# [v0.7.6](v0.7.5...v0.7.6) (2022-12-22)

## 🐛 Bug Fixes
- [`92169f8`](92169f8)  CI/CD Triggers (#174) (Issues: [`#174`](#174))

* ✨ GoingToCamp Provider 🏕 (#99)

* Add going to camp support

* Fix type hints for _fetch_nested_keys

* Add missing 'provider' argument to 'campsites()'

* Fix invalid equipment parameter name

* Fix provider config for recreation-areas

* flake8 can get some satisfaction

* Add python tests for going to camp search

* Fix recursive resource fetch bug

* Revert back to requipment-id instead of changing the --equipment API

* Check off the final TODO list

* Update camply/search/search_going_to_camp.py

* Update camply/search/search_going_to_camp.py

* Refactor 'self->cls' in validator

* Add multiple search window support to search library

* Coerce start date to 'today' when it's in the past

* Skip all sites with zero capacity

* ✅ Testing Improvements: Cassettes and CLIRunner (#155)

* Add going to camp support

* Fix type hints for _fetch_nested_keys

* Add missing 'provider' argument to 'campsites()'

* Fix invalid equipment parameter name

* Fix provider config for recreation-areas

* flake8 can get some satisfaction

* Add python tests for going to camp search

* Fix recursive resource fetch bug

* Revert back to requipment-id instead of changing the --equipment API

* Testing Improvements: Cassettes and CLIRunner

* Testing Improvements: Cassettes and CLIRunner

* Testing Improvements: Cassettes and CLIRunner

* Testing Improvements: Cassettes and CLIRunner

* Testing Improvements: Cassettes and CLIRunner

* Check off the final TODO list

* Testing Improvements: Cassettes and CLIRunner

* Testing Improvements: Cassettes and CLIRunner

* Update camply/search/search_going_to_camp.py

* Update camply/search/search_going_to_camp.py

* Refactor 'self->cls' in validator

* Add multiple search window support to search library

* Coerce start date to 'today' when it's in the past

* GoingToCamp + Tests

* 🚧 Merging Latest

Co-authored-by: Adriano Caloiaro <code@adriano.fyi>
Co-authored-by: Adriano <3331648+acaloiaro@users.noreply.github.com>

* 📌 dependency updates (#172)

* 🔒 dependency updates

* 🔒 dependency updates

* 🔒 dependency updates

* 📝 Providers Documentation (#156)

* feature/goingtocamp

* Add a blurb about GoingToCamp provider (#175)

* GoingToCamp Documentation

* GoingToCamp Documentation

* GoingToCamp Documentation

Co-authored-by: Adriano Caloiaro <3331648+acaloiaro@users.noreply.github.com>

* 🔖 0.8.0

# [v0.8.0](v0.7.6...v0.8.0) (2022-12-27)

## ✨ New Features
- [`6620f4c`](6620f4c)  GoingToCamp Provider 🏕 (#99) (Issues: [`#99`](#99))

* 📌 Lock File

* Merge branch 'main' into tours

Co-authored-by: Jingyuan Liang <jingyuanliang@google.com>
Co-authored-by: semantic-release-bot <semantic-release-bot@martynus.net>
Co-authored-by: Adriano Caloiaro <3331648+acaloiaro@users.noreply.github.com>
Co-authored-by: Adriano Caloiaro <code@adriano.fyi>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@juftin juftin

Labels

bug Something isn't working testing Testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@juftin @acaloiaro