Skip to content

chore: update doc heading#123

Merged
jujubot merged 1 commit intojuju:v3from
kian99:update-doc-heading
Jan 29, 2025
Merged

chore: update doc heading#123
jujubot merged 1 commit intojuju:v3from
kian99:update-doc-heading

Conversation

@kian99
Copy link
Copy Markdown
Contributor

@kian99 kian99 commented Jan 28, 2025

This PR updates the documentation markdown generator. Specifically, it changes document headings from UpperCase() to LowerCase( ).

E.g. a command like juju add-controller would include a title of ADD-CONTROLLER but with this change becomes juju add-controller and better reflects the CLI usage.
This shouldn't affect Juju documentation because there the title is often excluded since each command is documented on a different page, but for other tools using this package the title is more useful.

This change was prompted by the jimmctl reference docs at https://canonical-jaas-documentation.readthedocs-hosted.com/en/latest/reference/jimmctl/ cc @tmihoc

Partially fixes JUJU-7372

Update doc headings from UpperCase(<sub-command>) to LowerCase(<base-command> <sub-command>).
E.g. a command like `juju add-controller` would receive a title of `ADD-CONTROLLER` but is now `juju add-controller` to better reflect the CLI usage.
This shouldn't affect Juju documentation because there the title is often excluded since each command is documented on a different page, but for other tools using this package the title is more useful.
@kian99 kian99 requested a review from tmihoc January 28, 2025 10:52
Copy link
Copy Markdown
Member

@tmihoc tmihoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@kian99
Copy link
Copy Markdown
Contributor Author

kian99 commented Jan 29, 2025

/merge

@jujubot jujubot merged commit 0359742 into juju:v3 Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants