feat: import/export charm actions, config and lxd-profile#151
Merged
feat: import/export charm actions, config and lxd-profile#151
Conversation
Charm actions can be used to ensure RI (referential integrity) when constructing a charm/application in Juju 4.0.
This adds charm configs to the description package. It should be noted that there already exists a CharmConfig in the application already, but that is the current values of the config. What this is representing is the actual charm config. It should be noted that CharmConfig was originally called settings, which doesn't help either.
This also adds the LXD profile to the charm metadata. Adding this to charm metadata as a blob allows us to pass it through without it being incorrectly interpreted as a yaml.
SimonRichardson
changed the title
manadart
approved these changes
Jul 31, 2024
Member
Author
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Import/export charm actions, config, and lxd-profiles for a given charm. These represent the actual files that can be found in a charm. We require these configuration files, so that when we import a 3.6 or 4.0 model into a 4.0 controller, we can correctly infer all of the RI (referential integrity) when creating applications.