(Bug in client/connection.py) "raise websockets.exceptions.ConnectionClosed" needs a 'Close' object, not the code and reason directly.

[boltex]

As per https://websockets.readthedocs.io/en/stable/reference/exceptions.html#websockets.exceptions.ConnectionClosed The parameters need to be 'Close' object, not a number code and reason string as seen on line 483.

python-libjuju/juju/client/connection.py

Line 483 in 2581b0c

raise websockets.exceptions.ConnectionClosed(0, 'websocket closed')

[cderici]

Thanks for catching this, @boltex! I think you're right 👍

[boltex]

@cderici No problem!
Note: The few code bases that create a websockets.exceptions.ConnectionClosed on github have this bug. So chatGPT and copilot propose that same error! ...that's how I got it wrong in my project also and stumbled on your project when trying to see some examples!

[github-actions]

This issue is marked as incomplete because it has been open 30 days with no activity. Please remove incomplete label or comment or this will be closed in 5 days.

[cderici]

Closed by #990