-
Notifications
You must be signed in to change notification settings - Fork 101
Resolve build problems in 3.3.1.0 #1026
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
8132055
fe84880
c05cccb
3bdb58e
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -12,4 +12,5 @@ paramiko | |
| macaroonbakery | ||
| toposort | ||
| python-dateutil | ||
| kubernetes | ||
| kubernetes | ||
| packaging | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,19 +1,8 @@ | ||
| # Copyright 2023 Canonical Ltd. | ||
| # Licensed under the Apache V2, see LICENCE file for details. | ||
|
|
||
| import pathlib | ||
| import re | ||
|
|
||
| LTS_RELEASES = ["jammy", "focal", "bionic", "xenial", "trusty", "precise"] | ||
|
|
||
| DEFAULT_ARCHITECTURE = 'amd64' | ||
|
|
||
| # CLIENT_VERSION (that's read from the VERSION file) is the highest Juju server | ||
| # version that this client supports. | ||
| # Note that this is a ceiling. CLIENT_VERSION <= juju-controller-version works. | ||
| # For CLIENT_VERSION < juju-controller-version (strictly smaller), we emit a warning | ||
| # to update the client to the latest. | ||
| # However, for any CLIENT_VERSION > juju-controller-version, a "client incompatible | ||
| # with server" will be returned by the juju controller. | ||
| VERSION_FILE_PATH = pathlib.Path(__file__).parent.parent / 'VERSION' | ||
| CLIENT_VERSION = re.search(r'\d+\.\d+\.\d+', open(VERSION_FILE_PATH).read().strip()).group() | ||
| CLIENT_VERSION = "3.3.1.0" |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,6 +5,8 @@ | |
|
|
||
| from setuptools import find_packages, setup | ||
|
|
||
| from juju.version import CLIENT_VERSION | ||
|
|
||
| here = Path(__file__).absolute().parent | ||
| readme = here / 'docs' / 'readme.rst' | ||
| changelog = here / 'docs' / 'changelog.rst' | ||
|
|
@@ -13,11 +15,10 @@ | |
| changelog.read_text() | ||
| ) | ||
| long_description_content_type = 'text/x-rst' | ||
| version = here / 'VERSION' | ||
|
|
||
| setup( | ||
| name='juju', | ||
| version=version.read_text().strip(), | ||
| version=CLIENT_VERSION.strip(), | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do we still need to strip?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We currently don't need to, but the line that's coming from will be manually edited by people who're making releases (replaces the file VERSION) in the future, so I thought this would cleanup any silly mistakes like "4.2.0 " (whitespace in the end). |
||
| packages=find_packages( | ||
| exclude=["*.tests", "*.tests.*", "tests.*", "tests"]), | ||
| package_data={'juju': ['py.typed']}, | ||
|
|
@@ -32,6 +33,7 @@ | |
| 'typing_inspect>=0.6.0', | ||
| 'kubernetes>=12.0.1', | ||
| 'hvac', | ||
| 'packaging', | ||
| ], | ||
| include_package_data=True, | ||
| maintainer='Juju Ecosystem Engineering', | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -40,6 +40,7 @@ deps = | |
| websockets | ||
| kubernetes | ||
| hvac | ||
| packaging | ||
|
|
||
| [testenv:docs] | ||
| deps = | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Imports should be at the top no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one should stay there because it won't work before the
sys.path.insert(0, os.path.abspath('..'))line above