Add build test and update issue template#1030
Merged
jujubot merged 8 commits intojuju:masterfrom Feb 29, 2024
Merged
Conversation
As we run some of the targets in a non-tox environment (where tox/py3/bin/python doesn't exist)
jack-w-shaw
approved these changes
Feb 29, 2024
Contributor
Author
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This does two things:
Adds a Makefile target called
build-testthat runs thesetup.py sdistand installs the artifact in a virtual environment and runs a very simple command on it. The purpose of this is to catch the build and runtime dependency problems early on whenever a change is made that'll effect the release down the road (i.e. before it blows up when a new version is released). We add it into a GH action job as well to automatically catch these issues.For example, having something like this would've saved us from hitting Libjuju 3.3.1.0 is unusable #1025 on the
3.3.1.0release, which is the sole reason we had to make a new release https://github.com/juju/python-libjuju/releases/tag/3.3.1.1 afterwards.Updates the bug report template and adds
Please provide a simplified reproducer, and if it's possible please refrain from providing a "clone this repository and run the integration tests to see the problem" type of a reproducer. Thanks!, which is pretty self-explanatory.QA Steps
Just running the make target to see if it succeeds locally should be sufficient to QA this:
And maybe some manual checking for typos in the template message (b/c user-facing) could help.