Skip to content

Add build test and update issue template#1030

Merged
jujubot merged 8 commits intojuju:masterfrom
cderici:build-test-and-issue-template
Feb 29, 2024
Merged

Add build test and update issue template#1030
jujubot merged 8 commits intojuju:masterfrom
cderici:build-test-and-issue-template

Conversation

@cderici
Copy link
Copy Markdown
Contributor

@cderici cderici commented Feb 22, 2024

Description

This does two things:

  1. Adds a Makefile target called build-test that runs the setup.py sdist and installs the artifact in a virtual environment and runs a very simple command on it. The purpose of this is to catch the build and runtime dependency problems early on whenever a change is made that'll effect the release down the road (i.e. before it blows up when a new version is released). We add it into a GH action job as well to automatically catch these issues.
    For example, having something like this would've saved us from hitting Libjuju 3.3.1.0 is unusable #1025 on the 3.3.1.0 release, which is the sole reason we had to make a new release https://github.com/juju/python-libjuju/releases/tag/3.3.1.1 afterwards.

  2. Updates the bug report template and adds Please provide a simplified reproducer, and if it's possible please refrain from providing a "clone this repository and run the integration tests to see the problem" type of a reproducer. Thanks!, which is pretty self-explanatory.

QA Steps

Just running the make target to see if it succeeds locally should be sufficient to QA this:

make build-test

And maybe some manual checking for typos in the template message (b/c user-facing) could help.

@cderici cderici added kind/maintenance hint/3.x going on main branch labels Feb 22, 2024
@cderici
Copy link
Copy Markdown
Contributor Author

cderici commented Feb 29, 2024

/merge

@jujubot jujubot merged commit fbfa21b into juju:master Feb 29, 2024
@Aflynn50 Aflynn50 mentioned this pull request Mar 25, 2024
jujubot added a commit that referenced this pull request Mar 27, 2024
#1037

## What's Changed

* Add build test and update issue template by @cderici in #1030
* fix: machine scp & ssh by @yanksyoon in #1020
* Bugfix none type on master by @Aflynn50 in #1036
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hint/3.x going on main branch kind/maintenance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants