Conversation
cderici
approved these changes
Mar 22, 2024
Contributor
There was a problem hiding this comment.
Yeah the CI is unrelated, and will be fixed soon by the recent changes.
Can we also take care of these warnings as a drive-by, I fixed it in 3.x, and I thought I back-ported it, but looks like it fell through the cracks. Feel free to just cherry-pick those into this one or open another PR either is fine 👍
Thanks for the fix!
... already exists in integration/test_unit
Aflynn50
force-pushed
the
bugfix-NoneType
branch
from
11a7cdc to
e89d766
Compare
Aflynn50
force-pushed
the
bugfix-NoneType
branch
from
e89d766 to
4f164a3
Compare
Contributor
Author
|
/merge |
This was referenced Mar 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
<Please add why this change is needed and what it does.>
Fix for #1028
The logger is not passed to calls of
utils.run_with_interuptfrom model.py and controller.py. The default value isNone, so when it is later used we get the error.<Fixes: >
QA Steps
Added a
raise Exception("my random exception")to theNextmethod ofModelSummeryWatcherFacade. This is hit by therun_with_interuptin controller and we can observe that when we run the filemodelsummaries.py, if the log arguments added in this PR are not there then we get the None Type error and if they are there, we do not.Jira: JUJU-5610