Merged
Conversation
jack-w-shaw
force-pushed
the
fix_deploy_bundle_tests
branch
2 times, most recently
from
06d6f03 to
dea3cc6
Compare
cderici
approved these changes
Apr 30, 2024
Contributor
|
/merge |
It turns out a number of our test bundles were invalid, something only caught out by stricter param validating by juju controllers in 2.9.47 Fix these bundles + overlays to be valid
jack-w-shaw
force-pushed
the
fix_deploy_bundle_tests
branch
from
dea3cc6 to
5a713d6
Compare
Contributor
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
It turns out a number of our test bundles were invalid, something only caught out by stricter param validating by juju controllers in 2.9.47
Fix these bundles + overlays to be valid
QA Steps
All CI tests need to pass.