fix: Application.local_refresh method signature#1114
Merged
Conversation
dimaqq
requested review from
Aflynn50,
jack-w-shaw and
james-garner-canonical
dimaqq
force-pushed
the
fix-local-refresh
branch
from
c657340 to
c984a83
Compare
Contributor
Author
|
squashed and rebased to pass commit lint |
james-garner-canonical
approved these changes
Sep 27, 2024
Contributor
james-garner-canonical
left a comment
james-garner-canonical
left a comment
There was a problem hiding this comment.
Looks good, thanks. You might need to (re?)sign your commits to merge.
Aflynn50
reviewed
Sep 27, 2024
Contributor
Aflynn50
left a comment
Aflynn50
left a comment
There was a problem hiding this comment.
Looks good, could you include the integration test steps in the PR description? Either just which of the pylibjuju integration tests were run, or if local refresh is not used in there, just a code snippet that tests the functionality .
benhoyt
reviewed
Sep 29, 2024
dimaqq
force-pushed
the
fix-local-refresh
branch
from
172f9ea to
ac96d6c
Compare
dimaqq
force-pushed
the
fix-local-refresh
branch
from
7b1650e to
305b41a
Compare
dimaqq
force-pushed
the
fix-local-refresh
branch
from
305b41a to
be8b2cb
Compare
Contributor
Author
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1100
Closes #881
Charmers already pass a Path to refresh() in integration tests.
This PR standardises that.
Making arguments to local_refresh() explicit, as charmer don't get the default values.
Existing integration test is updated.
Jira: https://warthogs.atlassian.net/browse/CHARMTECH-309