Enable attachment of binary files as charm resources

[nrobinaubertin]

Description

This enables the attachment of binary files as charm resources.

Fixes: #1000

[jujubot]

Thanks for opening a pull request! Please follow the instructions here to ensure your pull request is ready for review. Then, a maintainer will review your patch.

@hpidcock @anvial

[jujubot]

Thanks for opening a pull request! Please follow the instructions here to ensure your pull request is ready for review. Then, a maintainer will review your patch.

@hpidcock @anvial

[dimaqq]

@nrobinaubertin this PR needs some kind of test.

ideally an integration test, or
a series of steps (this exact charm, this bootstrap, this deploy with this binary artifact)

[gfouillet]

Nothing to more than dima.

• Please add a test that would trigger the bug if not fixed
• take care of all call site of _upload to ensure data type consistency.

[dimaqq]

Niels, I see that the PR where you needed this was closed.

Do you have the bandwidth to update this PR?

If not, I can maybe create an issue based on the PR and eventually someone else can pick this up. What you're fixing is basically a bug, as binary resources should be supported.

[dimaqq]

This PR needs to be rebased since #1186 has been merged.

[nrobinaubertin]

I see that the PR where you needed this was closed.

I'm still using the feature but I'm using my patch locally

Do you have the bandwidth to update this PR?

Not right now, so if you feel we should close this PR, we can do it and I may reopen it later.
The patch in itself is tiny and straightforward, but I would need a bit of spare time to write the tests

If not, I can maybe create an issue based on the PR and eventually someone else can pick this up. What you're fixing is basically a bug, as binary resources should be supported.

There is already an issue, #1000

[dimaqq]

• rebased
• fixed the yaml code path
• added type hints

[dimaqq]

Moved to #1218