Skip to content

chore: don't merge, testing .open and .closed #1209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dimaqq wants to merge 1 commit into from
Closed

chore: don't merge, testing .open and .closed #1209

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions juju/client/connection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,7 @@ def status(self):
)

if stopped or not connection._ws.open:
raise BaseException("FIXME just testing not open")
return self.ERROR

# everything is fine!
Expand Down Expand Up @@ -358,6 +359,7 @@ async def close(self, to_reconnect: bool = False):
self._debug_log_task.cancel()

if self._ws and not self._ws.closed:
raise BaseException("FIXME just testing two")
await self._ws.close()

if not to_reconnect:
Expand Down