[JUJU-858] Add quality of life feature ensure application removal at return#665
Merged
jujubot merged 1 commit intojuju:masterfrom Apr 19, 2022
Merged
[JUJU-858] Add quality of life feature ensure application removal at return#665jujubot merged 1 commit intojuju:masterfrom
jujubot merged 1 commit intojuju:masterfrom
Conversation
Contributor
Author
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is to make life easier by allowing the following pattern:
to be written as:
Fixes #656
QA Steps
Notes & Discussion
Another option would be to do
await ops_test.model.applications[related_app.name].remove(block_until_done=True), however, then it gets weird to ask theapp.modeltoblock_untiltheapp.nameis no longer inmodel.applicationswhile theappobject is being torn down.