Conversation
The python-libjuju 2.9.46 release introduced the use of the walrus operator which is incompatible with python 3.6, more details at juju/python-libjuju#993
|
If this is the only breaking point for 3.6, I won't be against removing this particular use of the walrus, just to unblock you. However, it's important to note that we dropped support for python < 3.8 a long while ago, and will soon be moving to support 3.11-3.12 and 3.13. So you should expect more things to fail if you continue using python < 3.8. |
The python-libjuju 2.9.45 release introduced the use of the walrus operator which is incompatible with python 3.6, more details at juju/python-libjuju#993
juju/utils.py
Outdated
| juju_data = os.environ.get('JUJU_DATA') | ||
| # Secondly check: $XDG_DATA_HOME for ~/.local/share | ||
| elif xdg_data_home := os.environ.get('XDG_DATA_HOME'): | ||
| xdg_data_home = os.environ.get('XDG_DATA_HOME') |
There was a problem hiding this comment.
No need to get this if the juju_data is available. Please put it in the else case down below.
I understand the desire (and need) to drop support for old versions of python, although this is the |
|
/merge |
|
@freyes All the commits need to be signed to be able to land this, please rebase with |
since I will need to do a "push --force", do you mind if I squash those two commits into a single one?, it would make history cleaner. |
The walrus operator (`:=`) was introduced in Python 3.8, the use of it in the `2.9` branch breaks python 3.6 compatibility which is the version used in Ubuntu 18.04 (Bionic). https://docs.python.org/3/whatsnew/3.8.html#assignment-expressions
cderici
left a comment
cderici
left a comment
There was a problem hiding this comment.
since I will need to do a "push --force", do you mind if I squash those two commits into a single one?, it would make history cleaner.
I'd even prefer it that way, thanks a lot for taking care of this, this is good to go 👍
|
/merge |
#1023 ## What's Changed * Drop use of walrus operator by @freyes in #993 * No controller model access needed for connection with a non-admin user by @cderici in #1003 * Password resolution in connector by @cderici in #1002 * Remove dependency to juju-cli for controller_name by @cderici in #1009 #### Notes & Discussion JUJU-5413
3 participants
Description
The walrus operator (
:=) was introduced in Python 3.8, the use of it in the2.9branch breaks python 3.6 compatibility which is the version used in Ubuntu 18.04 (Bionic).https://docs.python.org/3/whatsnew/3.8.html#assignment-expressions
QA Steps
All CI tests need to pass.
Notes & Discussion
This regression was introduced by #975