Review examples

[joaquimg]

replaces #95

[joaquimg]

@matbesancon should we keep:

"../examples/unit_example.jl"
"../examples/chainrules.jl"

?

I removed the custom SVM example with flux because it did not use DiffOpt, the derivatives were set to zero.

I might bring back "solve conic" without cvxpy and sensible results

[codecov]

Codecov Report

Merging #164 (5d62b45) into master (56cb0e0) will decrease coverage by 0.12%.
The diff coverage is 100.00%.

❗ Current head 5d62b45 differs from pull request most recent head ec9b596. Consider uploading reports for the commit ec9b596 to get more accurate results

@@            Coverage Diff             @@
##           master     #164      +/-   ##
==========================================
- Coverage   86.26%   86.14%   -0.13%     
==========================================
  Files           7        7              
  Lines         830      837       +7     
==========================================
+ Hits          716      721       +5     
- Misses        114      116       +2     

Impacted Files	Coverage Δ
src/diff_opt.jl	87.60% <ø> (ø)
src/quadratic_diff.jl	99.17% <100.00%> (+0.05%)	⬆️
src/jump_moi_overloads.jl	62.85% <0.00%> (-1.91%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56cb0e0...ec9b596. Read the comment docs.

[matbesancon]

"../examples/unit_example.jl"
"../examples/chainrules.jl"

you mean given that we have a corresponding tutorial? Or do you think they are too redundant with one another?

[joaquimg]

you mean given that we have a corresponding tutorial? Or do you think they are too redundant with one another?

Yes, I think they are a bit redundant.
I would vote for keeping just chainrule_unit, the tutorial, that is a nice and complete example.

[joaquimg]

Good to merge on my side.
If you like to chat about it let me know @matbesancon , we might be better talking offline if you think there are too many changes.

[matbesancon]

I would vote for keeping just chainrule_unit, the tutorial, that is a nice and complete example.

agreed on that yes it makes sense