Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #356 +/- ##
==========================================
- Coverage 90.73% 90.50% -0.24%
==========================================
Files 16 16
Lines 2300 2339 +39
==========================================
+ Hits 2087 2117 +30
- Misses 213 222 +9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
So I built a draft implementation for Moreau.jl using this branch; it worked really well! Thank you. A few issues that popped up:
Overall, I think a bunch of this is just API differences, and probably can't be fixed at this point, but figured it was worth mentioning. |
|
This looks good to merge, let me know if there are any comments |
| function JuMP.coefficient( | ||
| func::MOI.ScalarAffineFunction{T}, | ||
| vi::MOI.VariableIndex, | ||
| ) where {T} |
There was a problem hiding this comment.
It's maybe not needed in the end, let me check
| MOI.supports(model::Optimizer, attr::ForwardDifferentiate) = true | ||
|
|
||
| function MOI.set(model::Optimizer, attr::ForwardDifferentiate, value) | ||
| st = MOI.get(model.optimizer, MOI.TerminationStatus()) |
There was a problem hiding this comment.
Is there reasonable precedence for this?
There was a problem hiding this comment.
Using MOI.set to trigger a computation ? I don't think so but I think it's the most layer-friendly approach
|
I am a bit surprise |
Ah yes, it wasn't needed at the end, it can just always use |
4 participants
First commit by Claude Code during our meeting based on this prompt #344 (comment)
Then I took over
Closes #344