Conversation
mlubin
approved these changes
Mar 2, 2021
Member
mlubin
left a comment
There was a problem hiding this comment.
Makes sense to me, pretty clean fix. Agreed it should be for MOI 0.10.
blegat
approved these changes
Mar 2, 2021
Member
blegat
left a comment
There was a problem hiding this comment.
Looks good. I don't think it's breaking. We can release this in a patch release. It only affect the state in AUTOMATIC mode anyway
odow
commented
Mar 2, 2021
7 tasks
blegat
approved these changes
Apr 30, 2021
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another way of fixing #1249.
The default of a
CachingOptimizeris to initialize inATTACHED_OPTIMIZERmode. This has two consequences:copy_toavailable.It seems like a much more sensible default is to initialize in
EMPTY_OPTIMIZERmode.copy_toif available.This is breaking (see the test change), so we may want to hold off until MOI 0.10, but it does need doing.