You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The StructOfConstraints macro is needed, e.g. for solvers that have a separate matrix for equality constraints and conic constraints, e.g., ECOS.
Using Box in MOIU.Model allows to share code between MatrixOfConstraints and AbstractModel, notably the getter for AbstractSet which has a few methods.
For the getters, I get we could choose not to implement them but they are quite straightforward and if they are not supported, then the hacks we will need in the tests of the solver wrappers using a MatrixOfConstraints as cache would be more work than this PR (and maintaining these features). Moreover, having them allows to use more modellike tests like the one added in this PR which is quite useful to ensure that MatrixOfConstraints behaves consistenctly with how a good ModelLike should behave.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Various improvements to
MatrixOfConstraints. It can now pass the relevant tests inTest/modellike.jl.StructOfConstraintsand improveStructOfConstraintsso that sub-fields can beMatrixOfConstraintss.BoxinMOIU.Modelfor storing variable bounds.