Conversation
Member
Author
|
That's quite a large coverage drop, so I'll hold off merging until that is resolved. This is a good example that refactoring the tests is useful! The files should be independently tested. We shouldn't have a big drop in coverage for sparse_matrix.jl by changing these tests. Of course, it makes my earlier statement incorrect at present:
😢
|
This was referenced Jul 15, 2021
Merged
odow
force-pushed
the
od/test-moc
branch
3 times, most recently
from
b6b48f1 to
ec6fece
Compare
Member
Author
|
This is now in a better state: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1398
Interested to see what this does to the code coverage. The previous tests in this file were pretty haphazard, and it's not obvious which tests were testing what.
The individual components (ProductOfSets, MutableSparseMatrixCSC, etc.) are independently tested, so I don't see the need for wide-scale testing on lots of different types.