Skip to content

WIP: rationalize dispatch code#78

Closed
odow wants to merge 5 commits intomasterfrom
od/tidy
Closed

WIP: rationalize dispatch code#78
odow wants to merge 5 commits intomasterfrom
od/tidy

Conversation

@odow
Copy link
Copy Markdown
Member

@odow odow commented Jan 19, 2021

This PR is an attempt to understand the MA dispatch code and remove some unneeded functions.

I will split the PR into smaller chunks, but I just wanted to see if it passes CI, and where the coverage issues are.

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 19, 2021

Codecov Report

Merging #78 (d333f0c) into master (d514a51) will increase coverage by 1.01%.
The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #78      +/-   ##
==========================================
+ Coverage   85.36%   86.37%   +1.01%     
==========================================
  Files          19       19              
  Lines        1353     1314      -39     
==========================================
- Hits         1155     1135      -20     
+ Misses        198      179      -19     
Impacted Files Coverage Δ
src/dispatch.jl 49.33% <88.88%> (-0.67%) ⬇️
src/Test/generic.jl 24.00% <0.00%> (-8.00%) ⬇️
src/broadcast.jl 74.19% <0.00%> (-0.81%) ⬇️
src/rewrite.jl 89.88% <0.00%> (-0.71%) ⬇️
src/sparse_arrays.jl 85.12% <0.00%> (+3.97%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d514a51...d333f0c. Read the comment docs.

@odow
Copy link
Copy Markdown
Member Author

odow commented Oct 17, 2021

Closing as stale

@odow odow closed this Oct 17, 2021
@odow odow deleted the od/tidy branch October 17, 2021 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant