Implement dot_nonrecursive and add fused_map_reduce#87
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #87 +/- ##
=========================================
Coverage ? 84.82%
=========================================
Files ? 18
Lines ? 1535
Branches ? 0
=========================================
Hits ? 1302
Misses ? 233
Partials ? 0
Continue to review full report at Codecov.
|
blegat
force-pushed
the
bl/dot_nonrecursive
branch
from
e347bc7 to
101b9f3
Compare
odow
reviewed
Apr 10, 2021
blegat
force-pushed
the
bl/dot_nonrecursive
branch
from
2525a75 to
a08f112
Compare
Co-authored-by: Oscar Dowson <odow@users.noreply.github.com>
blegat
force-pushed
the
bl/dot_nonrecursive
branch
from
c489410 to
8d12514
Compare
odow
approved these changes
May 6, 2021
Member
odow
left a comment
odow
left a comment
There was a problem hiding this comment.
Did we try this with the DiffOpt example to see if it works?
Member
Author
|
No but it's exactly the use case we were discussing in #87 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JuliaLang/julia#36679 introduced a new function
_dot_nonrecursive.While this function does not exploit mutability, several methods redirect to it so implementing it allows to kill a few birds with one stone.
Our implementation of
dotwasn't really correct since we didn't calldotrecursively so this PR also fixes that.