Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #167 +/- ##
==========================================
+ Coverage 97.52% 97.54% +0.02%
==========================================
Files 5 5
Lines 1452 1468 +16
==========================================
+ Hits 1416 1432 +16
Misses 36 36 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
Nice! can you just add tests for constrained variable(s)? |
blegat
commented
Jan 22, 2025
joaquimg
reviewed
Jan 23, 2025
Member
joaquimg
left a comment
joaquimg
left a comment
There was a problem hiding this comment.
Only thing pending it the constraint index issue, or you plan to solve it in a follow up PR?
src/MOI_wrapper.jl
Outdated
| set::MOI.AbstractScalarSet, | ||
| ) | ||
| inner_vi, inner_ci = MOI.add_constrained_variable(model.optimizer, set) | ||
| return _add_variable(model, inner_vi), inner_ci # FIXME map inner_ci |
Member
There was a problem hiding this comment.
This still needs a fix, right? Otherwise, vi and ci wont actually match
src/MOI_wrapper.jl
Outdated
| set::MOI.AbstractVectorSet, | ||
| ) | ||
| inner_vis, inner_ci = MOI.add_constrained_variables(model.optimizer, set) | ||
| return _add_variable.(Ref(model), inner_vis), inner_ci # FIXME map inner_ci |
| optimizer = POI.Optimizer(NoFreeVariablesModel{Float64}()) | ||
| set = MOI.LessThan(1.0) | ||
| @test MOI.supports_add_constrained_variable(optimizer, typeof(set)) | ||
| x, c = MOI.add_constrained_variable(optimizer, set) |
Member
There was a problem hiding this comment.
we should probably add a test to check the match between ci and vi.
joaquimg
approved these changes
Aug 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using Mosek after a POI layer without any bridge in-between, the performance was catastrophic because the PSD variable where bridged to affine constraints as the bridges didn't see through the POI layers that PSD variables were supported.