Skip to content

Conversation

@araujoms
Copy link
Contributor

The 3.2.8 release of SCS added support for the complex PSD cone. Here I'm adding support for accessing it via the low-level interface. I'll add MOI support in a different PR, since @odow likes PRs to be as small as possible.

@araujoms
Copy link
Contributor Author

CI is failing because it's using CUDA 13, which SCS does not support. I can't figure out how to upperbound the version to 12.

Copy link
Member

@odow odow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your issue #312 implies that other cones were added. Do we not need to account for them also?

@araujoms
Copy link
Contributor Author

No, they were not included in the built binaries; to add them one needs to set an environmental variable and recompile.

@odow odow merged commit 9289a31 into jump-dev:master Aug 21, 2025
9 of 10 checks passed
P = spzeros(n, n)

sol = scs_solve(T, m, n, A, P, b, c, z, l, bu, bl, q, s, ep, ed, Float64[])
sol = scs_solve(T, m, n, A, P, b, c, z, l, bu, bl, q, s, cs, ep, ed, Float64[])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a breaking change to the SCS API???

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I merged because I don't know if many people are using the low-level API, and we can keep the MOI wrapper non-breaking. But I wonder if we should think about how to make this non-breaking

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll make a separate PR

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's easy to make it non-breaking, just add a scs_solve with the old arguments calling the new one.

But scs_solve is not exported, and when @kalmarek added previous cones here he didn't make it non-breaking, so I decided to follow his example.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #313

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants