-
Notifications
You must be signed in to change notification settings - Fork 25
low level support for the complex psd cone #311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
CI is failing because it's using CUDA 13, which SCS does not support. I can't figure out how to upperbound the version to 12. |
odow
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your issue #312 implies that other cones were added. Do we not need to account for them also?
|
No, they were not included in the built binaries; to add them one needs to set an environmental variable and recompile. |
| P = spzeros(n, n) | ||
|
|
||
| sol = scs_solve(T, m, n, A, P, b, c, z, l, bu, bl, q, s, ep, ed, Float64[]) | ||
| sol = scs_solve(T, m, n, A, P, b, c, z, l, bu, bl, q, s, cs, ep, ed, Float64[]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a breaking change to the SCS API???
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I merged because I don't know if many people are using the low-level API, and we can keep the MOI wrapper non-breaking. But I wonder if we should think about how to make this non-breaking
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll make a separate PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's easy to make it non-breaking, just add a scs_solve with the old arguments calling the new one.
But scs_solve is not exported, and when @kalmarek added previous cones here he didn't make it non-breaking, so I decided to follow his example.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See #313
The 3.2.8 release of SCS added support for the complex PSD cone. Here I'm adding support for accessing it via the low-level interface. I'll add MOI support in a different PR, since @odow likes PRs to be as small as possible.