fix: fix request field serialization across all request types#6
Merged
Conversation
Previously, required fields like `start_date`, `zip_code`, `lab_id`, `user_id`, `collection_date`, and `lab` were annotated with `@JsonIgnore`, causing them to be omitted from serialized request bodies. Optional fields (`end_date`, `provider`, `cursor`, `next_cursor`, etc.) also lacked proper `@JsonProperty` bindings and `NullableNonemptyFilter` handling. This fix ensures all request fields are correctly serialized when making API calls, resolving silent data-loss bugs where required parameters were never sent to the server. Key changes: - Replace `@JsonIgnore` with `@JsonProperty` on required fields across all request classes (activity, body, sleep, vitals, lab tests, link, meal, menstrual cycle, etc.) - Add private `@JsonProperty`-annotated accessors with `NullableNonemptyFilter` for all optional (`Optional<T>`) fields to ensure correct conditional serialization - Import `NullableNonemptyFilter` and `JsonProperty` in all affected request classes 🌿 Generated with Fern
ItachiEU
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1.0.0 → 1.0.1
Previously, required fields like
start_date,zip_code,lab_id,user_id,collection_date, andlabwere annotated with@JsonIgnore,causing them to be omitted from serialized request bodies. Optional fields
(
end_date,provider,cursor,next_cursor, etc.) also lacked proper@JsonPropertybindings andNullableNonemptyFilterhandling.This fix ensures all request fields are correctly serialized when making
API calls, resolving silent data-loss bugs where required parameters were
never sent to the server.
Key changes:
@JsonIgnorewith@JsonPropertyon required fields across all request classes (activity, body, sleep, vitals, lab tests, link, meal, menstrual cycle, etc.)@JsonProperty-annotated accessors withNullableNonemptyFilterfor all optional (Optional<T>) fields to ensure correct conditional serializationNullableNonemptyFilterandJsonPropertyin all affected request classes