FZF_COMPLETION_DIR_OPTS not respected when _fzf_compgen_dir is defined

[Maple38]

Checklist

• I have read through the manual page (man fzf)
• I have searched through the existing issues
• For bug reports, I have checked if the bug is reproducible in the latest version of fzf

Output of fzf --version

0.66.1 (brew)

OS

• Linux
• macOS
• Windows
• Etc.

Shell

• bash
• zsh
• fish

Problem / Steps to reproduce

Hi!

I was running into an issue where my FZF_COMPLETION_DIR_OPTS and FZF_COMPLETION_PATH_OPTS were not being respected. After much troubleshooting, it seems the issue only occurs when _fzf_compgen_path and _fzf_compgen_dir are defined.

Is there a way to fix this?

If it matters, here's the part of my .zshrc:

export FZF_DEFAULT_COMMAND='fd --hidden --follow'
export FZF_DEFAULT_OPTS='--style full'

export FZF_COMPLETION_OPTS='--style full'
export FZF_COMPLETION_DIR_OPTS='--preview="ls {}"'
export FZF_COMPLETION_PATH_OPTS='--preview="bat --color=always --style=numbers --line-range=:250 {}"'

_fzf_compgen_path() {
  fd -d 1 --type f --hidden --follow "$1"
}
_fzf_compgen_dir() {
  fd -d 1 --type d --hidden --follow "$1"
}

[LangLangBart]

Is there a way to fix this?

can u add these function to your setup and check if its working as expected ?

_fzf_path_completion() {
  __fzf_generic_path_completion "$1" "$2" _fzf_compgen_path \
    "${FZF_COMPLETION_PATH_OPTS-} -m" "" " "
}

_fzf_dir_completion() {
  __fzf_generic_path_completion "$1" "$2" _fzf_compgen_dir \
    "${FZF_COMPLETION_DIR_OPTS-}" "/" ""
}

---

if it does then the patch would just be:

--- a/shell/completion.zsh
+++ b/shell/completion.zsh
@@ -205,10 +205,10 @@ __fzf_generic_path_completion() {
 _fzf_path_completion() {
   __fzf_generic_path_completion "$1" "$2" _fzf_compgen_path \
-    "-m" "" " "
+    "${FZF_COMPLETION_PATH_OPTS-} -m" "" " "
 }
 
 _fzf_dir_completion() {
   __fzf_generic_path_completion "$1" "$2" _fzf_compgen_dir \
-    "" "/" ""
+    "${FZF_COMPLETION_DIR_OPTS-}" "/" ""
 }

[Maple38]

Doesn't appear to fix it sadly.

[LangLangBart]

Doesn't appear to fix it sadly.

did you add _fzf_path_completion and _fzf_dir_completion after running source <(fzf --zsh)

what is the output for typeset -f _fzf_path_completion ?

[Maple38]

Doesn't appear to fix it sadly.

did you add _fzf_path_completion and _fzf_dir_completion after running source <(fzf --zsh)

what is the output for typeset -f _fzf_path_completion ?

Oh wait, it does work now. Your solution did work. Not entirely sure what I did wrong when copy-pasting the first time, but it's fixed now! Thank you very much.