zsh foreign test #4622
Open
zsh foreign test #4622
+40
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows using alternative container runtimes, e.g., DOCKER=podman make docker-test
LangLangBart
commented
Dec 4, 2025
Comment on lines
+544
to
+547
| # NOTE: 'Perl/$history' won't see foreign cmds immediately, unlike 'awk/fc'. | ||
| # Perl passes only because another cmd runs between mocking and triggering C-r | ||
| # https://github.com/junegunn/fzf/issues/4061 | ||
| # https://zsh.org/mla/users/2024/msg00692.html |
Contributor
Author
There was a problem hiding this comment.
Just as a reminder
We can't use Perl/fc because, unlike bash, zsh escapes actual newlines as \n.
bash: fc preserves actual newlines
printf 'foo\n
bar\n'
# foo
# bar
fc -rl -1
# 1 printf 'foo\n
# bar\n'zsh: fc escapes newlines to \n
printf 'foo\n
bar\n'
# foo
# bar
fc -rl -1
# 1 printf 'foo\n\nbar\n'
printf '%s\t%s\n' "${(kv)history[@]}"
# 1 printf 'foo\n
# bar\n'...and trying to patch the issue by running fc -RI before calling the
$history array caused problems the last time we tried.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test(zsh): add test for C-r with foreign commands
Adds a test to retrieve foreign commands for user w/ SHARE_HISTORY set
ci: make docker command configurable via variable
allows me to run the test with podman