Skip to content

Add SlackLogFilter fixes #1 #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
junhwi merged 2 commits into from
Jul 18, 2017
Merged

Add SlackLogFilter fixes #1 #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2d852e2
Add SlackLogFilter fixes #1
browniebroke Jul 16, 2017
33158ca
Document SlackLogFilter in README
browniebroke Jul 16, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions README.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,3 +47,18 @@ Using logger
logger.warn('warn message')
logger.error('error message')
logger.critical('critical message')

Using filter
''''''''''''

You can also filter some messages only

.. code-block:: python

from slack_logger import SlackLogFilter

sf = SlackLogFilter()
sh.addFilter(sf)

logger.info('info message') # Not posted to slack
logger.info('info message to slack', extra={'notify_slack': True}) # Posted to slack
12 changes: 12 additions & 0 deletions slack_logger.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,3 +58,15 @@ def format(self, record):
ret['ts'] = record.created
ret['text'] = super(SlackFormatter, self).format(record)
return ret


class SlackLogFilter(logging.Filter):
"""
Logging filter to decide when logging to Slack is requested, using
the `extra` kwargs:

`logger.info("...", extra={'notify_slack': True})`
"""

def filter(self, record):
return getattr(record, 'notify_slack', False)